[sheepdog] [PATCH 1/2] functional: add 065 to test cache push

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Fri Jun 21 07:12:41 CEST 2013


At Fri, 21 Jun 2013 12:50:57 +0800,
Liu Yuan wrote:
> 
> On 06/21/2013 11:36 AM, MORITA Kazutaka wrote:
> > How about adding a option to use write cache for the check script?
> > 
> > For example,
> > 
> >  $ SHEEP_OPTIONS="-n -d -w size=400"./check -writeback
> > 
> > where -writeback adds '-w' to 'collie vdi write' and '-t writeback' to
> > qemu-io.  Then we can reuse all the existing testcases for testing the
> > object cache feature.
> 
> I'd like have -writeback do all the tricks. Anyway, this need more
> effort to have all the tests accommodate '-writeback' option and should
> be done by other patches.
> 
> At least please apply 065 test, this one reveal a bug that previous
> tests don't catch.

Applied both.

However, what this patch (065 test) does is very trivial except that
object cache is enabled.  If we could enable object cache for our test
framework, the existing tests would catch the same bug.

I'm going to add support for the object cache support to our testing
framework and reconsider again whether this test is really necessary
or not.

Thanks,

Kazutaka



More information about the sheepdog mailing list