[sheepdog] [PATCH v7 3/7] sheep: rejoin cluster after a zookeeper session timeout

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Jun 25 14:49:12 CEST 2013


Hi Kyle, I have a propose about this patchset.

At Sun, 23 Jun 2013 20:05:23 -0700,
Kai Zhang wrote:
> 
> Add sd_reconnect_handler() to group.c to handle reconnect issue.
> 
> Signed-off-by: Kai Zhang <kyle at zelin.io>
> ---
>  sheep/cluster.h           |    1 +
>  sheep/cluster/zookeeper.c |   36 +++++++++++++++++++++++++++++++++---
>  sheep/group.c             |   12 ++++++++++++
>  3 files changed, 46 insertions(+), 3 deletions(-)

The timeout handling part which is implemented in this patchset
(e.g. zoo_state(zhandle) == ZOO_EXPIRED_SESSION_STATE) is very
useful, because current master of sheepdog doesn't handle it well. And
it is causing problems in our internal use of sheepdog.

The reconnection part is also useful but the current patchset is big
and not review friendly.

I think they can be separated ones. Could you make a smaller patchset
which only solves the problem of zookeeper timeout? If you kindly make
it, I'd like to merge it to the stable branch.

Thanks,
Hitoshi



More information about the sheepdog mailing list