[sheepdog] [PATCH v2 1/7] md: add dummy md proper

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Mar 12 06:34:51 CET 2013


> +
> +struct disk {
> +	char path[PATH_MAX];
> +	uint16_t nr_vdisks;
> +	uint64_t space;
> +} md_disks[SD_MAX_DISK];
> +
> +struct vdisk {
> +	uint16_t idx;
> +	uint64_t id;
> +} md_vds[SD_MAX_VDISK];

These two variables should be static.

> +
> +#define RDNAME	"user.md.size"
> +#define RDSIZE	sizeof(uint64_t)

What do RDNAME and RDSIZE mean?  I think more descriptive names are
better.

Thanks,

Kazutaka



More information about the sheepdog mailing list