[sheepdog] [PATCH 2/2] tests/054:test automatic stale object purging

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Mar 19 08:52:26 CET 2013


At Tue, 19 Mar 2013 15:19:48 +0800,
Liu Yuan wrote:
> 
> On 03/16/2013 03:04 PM, wangfan wrote:
> > +#start recovery
> > + _start_sheep 3 "-s 3000"
> > +sleep 1
> 
> This sleep is not necessary because wait_for_sheep will do this internally.
> 
> > +_wait_for_sheep 4
> > +_wait_for_sheep_recovery 0
> > +$COLLIE cluster info | _filter_cluster_info
> > +
> > +sleep 1
> 
> Ditto.
> 
> > +#test no object in .stale
> 
> By the way, patch set (more than one patch) would better be grouped into
> one message group. You can easily achieve this by git send-email as
> following
>  $ git send-email -to sheepdog at lists.wpkg.org -2 # we send 2 commits or
>  $ git send-email -to sheepdog at lists.wpkg.org  file1 file2

I'd suggest using git format-patch with --cover-leter option and
describing what the patch series aims to achieve in the cover leter.

Thanks,

Kazutaka



More information about the sheepdog mailing list