At Sat, 18 May 2013 00:05:41 +0800,
Liu Yuan wrote:
>
> On 05/17/2013 11:16 PM, MORITA Kazutaka wrote:
> > Currently, 'collie vdi check' can repair objects in parallel, so we
> > cannot guarantee that sheep restores the first replica in this case.
> > This makes the test show the unique output in spite of the checked
> > order.
>
> What problem does this patch fix? From the output, looks no sorting
> issue, no?
The current test assumes that collie fixes replicas using the first one, but
it's no longer correct since 'vdi check' recovers replicas in parallel now.
Then we can get the following two kinds of tests and both are correct:
* if collie updates the 2nd and 3rd replica with the 1st one
[snip]
finish check&repair test
finish check&repair test
fixed replica 7c2b2500000001
fixed replica 7c2b2500000001
* if collie updates the 1st replica with 2nd (or 3rd) one
[snip]
finish check&repair test
finish check&repair test
fixed replica 7c2b2500000001
hello
To get a unique output, this series removes the duplicate
'fixed replica 7c2b2500000001' with 'uniq', and removes 'hello'
by dropping 'collie vdi read' from the test.
Thanks,
Kazutaka
|
|