[sheepdog] [PATCH v5 05/16] sheep: store.c don't include farm.h

MORITA Kazutaka morita.kazutaka at gmail.com
Mon May 20 21:08:02 CEST 2013


At Mon, 20 May 2013 15:50:35 +0800,
Kai Zhang wrote:
> 
> Signed-off-by: Kai Zhang <kyle at zelin.io>
> ---
>  sheep/sheep_priv.h |    6 +++---
>  sheep/store.c      |    1 -
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/sheep/sheep_priv.h b/sheep/sheep_priv.h
> index b66f348..1c33a3d 100644
> --- a/sheep/sheep_priv.h
> +++ b/sheep/sheep_priv.h
> @@ -26,6 +26,9 @@
>  #include "rbtree.h"
>  #include "strbuf.h"
>  
> +#define HEX_LEN  40
> +#define NAME_LEN HEX_LEN
> +

Please use more descriptive name because this header file is included all the
sheep source files.

How about SHA1_HEX_LEN and SHA1_NAME_LEN?

Thanks,

Kazutaka


More information about the sheepdog mailing list