On 05/21/2013 08:11 AM, MORITA Kazutaka wrote:
> +static inline bool is_ledger_obj(uint64_t oid)
> +{
> + return !!(oid & LEDGER_BIT);
> +}
Currently we are mixing 'obj' and 'object' name component in function
name. We are not in the old days that these several bytes saving will
make difference to memory or disk consumption. So I'd like to suggest
use of more complete name if possible. But for generally well received
name such as 'refcnt' should be retained as is though.
is_ledger_object() looks more meaning name to me, so as to other helper
functions in this patch set.
I'll cook a patch later to s/obj/object all the existing files to get a
more uniform view of function name.
Thanks,
Yuan
|
|