On 05/23/2013 05:49 PM, Liu Yuan wrote: > On 05/23/2013 05:45 PM, Kai Zhang wrote: >> I think the name of get_path_size() makes me confused. Actually, it >> returns free size and also set the second parameter as used size. > > No, this was supported to use all the free space of one disk, but for MD > case, we use the whole disk as a mandatory, so just return the total > size, this can be considered as a bug but xattr shadows it. > Well, with a second thought, if we remove xattr, we will have to use all the partition. For e.g, with one disk as /sheep/store and /other_stuff share it, so we don't want to use the whole disk obviously. Then if we don't store free size as total size at the time being plugged, your patch won't work because set the md disk as the total space of the disk. Thanks, Yuan |