[sheepdog] [PATCH] sockfd_cache: close socket always when node is crashed

MORITA Kazutaka morita.kazutaka at gmail.com
Thu May 2 04:51:35 CEST 2013


At Thu, 02 May 2013 10:17:32 +0800,
Liu Yuan wrote:
> 
> On 05/02/2013 12:50 AM, MORITA Kazutaka wrote:
> > When timeout happens, we cannot reuse the socket for other transfers
> > because data may remain in its send (or recv) buffer.  We have to
> > close the socket before making the sockfd_cache reusable.
> 
> I am wondering if we should add a dedicated handler for closing
> timeout-fd only, not destroy all the fds.

I'm not sure if I understand your suggestion correctly, but from the
point of view that we have to set false to .in_use and close the
timeout fd in the same lock context, adding another handler doesn't
look a good idea to me.

Thanks,

Kazutaka



More information about the sheepdog mailing list