[sheepdog] [PATCH 9/9] sheep: show error message when object may be lost

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue May 7 09:46:30 CEST 2013


At Tue, 07 May 2013 16:43:09 +0900,
MORITA Kazutaka wrote:
> 
> At Tue, 07 May 2013 15:13:12 +0800,
> Liu Yuan wrote:
> > 
> > +		case SD_RES_NO_OBJ:
> > +			/*
> > +			 * No object means that there was no write success at
> > +			 * this epoch.
> > +			 */
> > +			data_lost = false;
> > +			/* fall through */
> > 
> > So if A, B, C all return SD_RES_NO_OBJ, you set data_lost = false, in
> > this case, we don't print an error, no?
> 
> I set false to data_lost even when only one of nodes returns
> SD_RES_NO_OBJ.

Maybe, 'data_lost' is not a good name here.  I set false to it when
there is no possiblity that sheep returns the older data.

Thanks,

Kazutaka



More information about the sheepdog mailing list