[sheepdog] [PATCH] trivial: misc fixes of comments

Liu Yuan namei.unix at gmail.com
Wed May 8 05:04:18 CEST 2013


On 05/08/2013 12:00 AM, Hitoshi Mitake wrote:
> This patch fixes some incorrect comments:
> 1. group.c: colosync -> corosync
> 2. sockfd_cache.c: vnode -> node
> 3. sheep_priv.h: past -> part
> 4. group.c: the comment of leave_cluster()
> 
> 1 is a very trivial mistake. 2 wouldn't cause a serious confusion but
> the description is not correct. vnode is a concept of consisntent
> hashing and it is not a something connect to. 3 would be
> confusing. Because the way of dealing with exceptional nodes is subtle
> and hard to understand. 4 is the most serious misleading comment. IIUC,
> current sheep doesn't have a way of becoming a gateway node even if it
> faces EIO.

1, 2, 3 Looks fine to me. But 4 isn't correct, or I am missing
something? leave_cluster() is called at io_op_done() and
gateway_op_done() in EIO case, this doesn't work fine now?

Thanks,
Yuan



More information about the sheepdog mailing list