[sheepdog] [PATCH] trivial: misc fixes of comments
Hitoshi Mitake
mitake.hitoshi at gmail.com
Wed May 8 07:12:55 CEST 2013
At Wed, 08 May 2013 12:55:21 +0800,
Liu Yuan wrote:
>
> On 05/08/2013 11:45 AM, Hitoshi Mitake wrote:
> > Calling leave_cluster() invokes calling sd_leave_handler() on other
> > nodes. The sheep which called leave_cluster() simply vanishes from
> > an epoch without becoming a gateway node. So I think the above comment
> > is misleading.
>
> I don't get it. After calling leave_cluster(), the node isn't gateway
> node? VM can still connect to this node and requests will be routed to
> the cluster via this node. Am I missing something?
No. The node simply leaves from the cluster. But it doesn't mean the
node always dies. The node keeps connection to a cluster manager can
resend join request again.
The leaved sheep marks itself as a node with 0 vnodes in
sd_leave_handler() (I'm not sure it is really required). But the node
doesn't become a gateway node. Because other nodes increment their
epoch and exclude the node from their views.
Thanks,
Hitoshi
More information about the sheepdog
mailing list