[sheepdog] [PATCH v3 09/12] sheep: add a flag to let notify_vdi_add set bitmap if needed
MORITA Kazutaka
morita.kazutaka at gmail.com
Tue May 14 18:07:57 CEST 2013
At Tue, 14 May 2013 15:51:54 +0800,
Kai Zhang wrote:
>
> Add a bool flag "set_bitmap" to sd_req.vdi_state.
> Function notify_vdi_add will set bitmap if "set_bitmap" is true.
>
> This feature will be used to recover vdi state and vdi bitmap
> on all nodes after loading snapshot to a new cluster.
>
> Signed-off-by: Kai Zhang <kyle at zelin.io>
> ---
> include/sheepdog_proto.h | 7 ++++---
> sheep/ops.c | 3 +++
> sheep/vdi.c | 1 +
> 3 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/include/sheepdog_proto.h b/include/sheepdog_proto.h
> index 0916948..e170200 100644
> --- a/include/sheepdog_proto.h
> +++ b/include/sheepdog_proto.h
> @@ -143,6 +143,7 @@ struct sd_req {
> uint32_t old_vid;
> uint32_t new_vid;
> uint32_t copies;
> + bool set_bitmap;
> } vdi_state;
The size of bool depends on the machine architecture, so it's not appropriate
for the network protocol structure. Please use uint8_t, uint16_t, or uint32_t
instead.
Thanks,
Kazutaka
More information about the sheepdog
mailing list