On 05/17/2013 02:27 PM, Kai Zhang wrote: > + /* create active vdi based on last vdi snapshot */ > + struct vdi_entry *vdi, *next; > + uint32_t new_vid; Declaration in the middle looks odd to me. I'd suggest declare them in the beginning. Thanks, Yuan