[sheepdog] [PATCH 2/2] collie: show 'auto-recovery' status for 'cluster info'

Liu Yuan namei.unix at gmail.com
Tue May 21 04:55:20 CEST 2013


On 05/21/2013 01:56 AM, MORITA Kazutaka wrote:
> +	uint16_t nr_nodes;
> +	uint8_t disable_recovery;
> +	uint8_t __pad;

This will segfault the collie, I am not sure why. But

uint8_t disable_recovery;
uint8_t __pad[3];

works. I am wondering to prevent GCC madness of choosing the structure
length, should we better off adding '__packed' explicitly to all the on
the wire structure?

Thanks,
Yuan



More information about the sheepdog mailing list