[sheepdog] [PATCH v5 05/16] sheep: store.c don't include farm.h

Kai Zhang kyle at zelin.io
Tue May 21 05:39:26 CEST 2013


On May 21, 2013, at 3:08 AM, MORITA Kazutaka <morita.kazutaka at gmail.com> wrote:

> At Mon, 20 May 2013 15:50:35 +0800,
> Kai Zhang wrote:
>> 
>> Signed-off-by: Kai Zhang <kyle at zelin.io>
>> ---
>> sheep/sheep_priv.h |    6 +++---
>> sheep/store.c      |    1 -
>> 2 files changed, 3 insertions(+), 4 deletions(-)
>> 
>> diff --git a/sheep/sheep_priv.h b/sheep/sheep_priv.h
>> index b66f348..1c33a3d 100644
>> --- a/sheep/sheep_priv.h
>> +++ b/sheep/sheep_priv.h
>> @@ -26,6 +26,9 @@
>> #include "rbtree.h"
>> #include "strbuf.h"
>> 
>> +#define HEX_LEN  40
>> +#define NAME_LEN HEX_LEN
>> +
> 
> Please use more descriptive name because this header file is included all the
> sheep source files.
> 
> How about SHA1_HEX_LEN and SHA1_NAME_LEN?


Accept.
This two lines are copied from sheep/farm.h.
I ignore to modify them.

Thanks,
Kyle


More information about the sheepdog mailing list