[sheepdog] [PATCH v2] collie: don't roundup vdi size

MORITA Kazutaka morita.kazutaka at gmail.com
Tue May 21 14:44:25 CEST 2013


At Tue, 21 May 2013 20:33:54 +0800,
Liu Yuan wrote:
> 
> On 05/21/2013 08:26 PM, MORITA Kazutaka wrote:
> > Nack, the data length must be sector aligned when we use direct I/O.
> > Can't we modify Glance sheepdog driver so that we don't need these
> > changes?
> 
> Just test create an image with size '3' and  write 'XXX' to it. When it
> reads the content, we return 512 bytes. so fail the test. But if user
> requests to read 3 bytes, we should return 3 bytes, no more no less if
> we later support an object store like swift and s3, no?

Yes.  Can you prepare a patch to drop O_DIRECT from the open flag when
offset and length are not sector aligned?  I think the patch should be
in the same series with this one.

Thanks,

Kazutaka



More information about the sheepdog mailing list