[sheepdog] [PATCH v4 08/12] gateway: don't skip start_recovery for gateway-only node

MORITA Kazutaka morita.kazutaka at gmail.com
Mon May 27 16:53:08 CEST 2013


At Mon, 27 May 2013 20:53:18 +0800,
Liu Yuan wrote:
> 
> Gateway node needs to notify completion to other nodes to purge stale objects.
> 
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
>  sheep/recovery.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/sheep/recovery.c b/sheep/recovery.c
> index ab99244..21d76e2 100644
> --- a/sheep/recovery.c
> +++ b/sheep/recovery.c
> @@ -782,9 +782,6 @@ int start_recovery(struct vnode_info *cur_vinfo, struct vnode_info *old_vinfo,
>  	struct recovery_info *rinfo;
>  	uint32_t old_epoch = epoch_lifted ? sys->epoch - 1 : sys->epoch;
>  
> -	if (node_is_gateway_only())
> -		goto out;
> -
>  	rinfo = xzalloc(sizeof(struct recovery_info));
>  	rinfo->state = RW_PREPARE_LIST;
>  	rinfo->epoch = sys->epoch;

I think we should set rinfo->state to RW_NOTIFY_COMPLETION to skip
gathering object lists.

Thanks,

Kazutaka



More information about the sheepdog mailing list