[sheepdog] [PATCH 1/2] sheep, dog: runtime loglevel changing

[Hitoshi Mitake]

At Sat, 19 Oct 2013 21:08:41 +0900,
Hitoshi Mitake wrote:
> 
> At Sat, 19 Oct 2013 14:24:54 +0800,
> Liu Yuan wrote:
> > 
> > On Fri, Oct 18, 2013 at 08:54:33PM +0900, Hitoshi Mitake wrote:
> > > This patch adds two new opcode for runtime loglevel changes and let
> > > dog support the changing from command line. This is useful for making
> > > sheep process verbose temporally and can make troubleshooting easier.
> > > 
> > > Example of usage:
> > > 
> > > $ dog node loglevel get
> > > info (6)
> > > $ dog node loglevel set debug	# <- change loglevel from info to debug
> > > $ dog node loglevel get
> > > debug (7)
> > 
> > I think 'node log' is a shorter thus better naming.  I'd suggest add a list
> > command that list the avaiable log levels.
> 
> OK, I'll rename the subcommand as "node log" and add a new command for
> printing available log levels.

On the second thought, I found that the name "node loglevel" would be
better. If we name the subcommand "node log", successor
sub-subcommands should be named "setlevel", "getlevel", and
"listlevel". I prefer "node loglevel {set, get, list}" for this
reason.

Thanks,
Hitoshi