[sheepdog] [PATCH] dog: fix return value of vdi_backup()

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Oct 29 02:14:24 CET 2013


At Tue, 29 Oct 2013 02:35:09 +0900,
Ryusuke Konishi wrote:
> 
> "dog vdi backup" command returns 16 as its status code even if it
> successfully ended.
> 
> This is because the current vdi_backup function returns the byte count
> returned by the last xwrite call in the function.
> 
> This fixes the issue by overwriting the return code with EXIT_SUCCESS
> at the end of the normal path of vdi_backup().
> 
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke at lab.ntt.co.jp>
> ---
>  dog/vdi.c |    1 +
>  1 file changed, 1 insertion(+)

Looks good to me, thanks for your fix.

Reviewed-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>

Thanks,
Hitoshi



More information about the sheepdog mailing list