[sheepdog] [PATCH v2 0/7] revive VDI locking mecahnism

[Hitoshi Mitake]

At Fri, 1 Aug 2014 11:05:44 +0200,
Valerio Pachera wrote:
> 
> I've been testing also kill and kill -9.
> With kill the lock gets removed.
> With kill -9 it doens't (as expected).
> 
> 'vdi lock force-unlock' works fine but I notices 2 things:
> 
> 1) the syntax doesn't mentions 'vdiname'
> dog vdi lock {list|force-unlock} [-a address] [-p port] [-h] [-t]
> it should be
> dog vdi lock {list|force-unlock} [-a address] [-p port] [-h] [-t] <vdiname>
> 
> 2) if I don't write any vdi name, it crashes:
> 
> dog vdi lock force-unlock
> dog exits unexpectedly (Segmentation fault).
> dog.c:374: crash_handler
> /lib/x86_64-linux-gnu/libpthread.so.0(+0xf02f) [0x7f834b7b402f]
> /lib/x86_64-linux-gnu/libc.so.6(+0x7f5b9) [0x7f834b0785b9]
> treeview.c:63: find_vdi_with_name
> vdi.c:2763: lock_force_unlock
> common.c:262: do_generic_subcommand
> dog.c:572: main
> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xfc) [0x7f834b017eec]
> dog() [0x4041a8]
> Segmentation fault

Oops, I'll fix them ASAP.

Thanks,
Hitoshi