[sheepdog] [PATCH] cluster/zookeeper: add log information for zk auto-recoonect
Hitoshi Mitake
mitake.hitoshi at lab.ntt.co.jp
Mon Aug 11 03:30:04 CEST 2014
At Fri, 8 Aug 2014 14:50:07 +0800,
Liu Yuan wrote:
>
> Reported-by: Valerio Pachera <sirio81 at gmail.com>
> Signed-off-by: Liu Yuan <namei.unix at gmail.com>
> ---
> sheep/group.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sheep/group.c b/sheep/group.c
> index 06a80bd..08e3884 100644
> --- a/sheep/group.c
> +++ b/sheep/group.c
> @@ -979,7 +979,7 @@ static int send_join_request(void)
> {
> struct sd_node *n = &sys->this_node;
>
> - sd_info("%s", node_to_str(n));
> + sd_info("%s going to rejoin the cluster", node_to_str(n));
send_join_request() is also called in create_cluster(). So
unconditionally logging "rejoin" is confusing log for users.
Change type of send_join_request() from
int send_join_request(void)
to
int send_join_request(bool rejoin)
and change log based on the new parameter rejoin would be good.
Thanks,
Hitoshi
> return sys->cdrv->join(n, &sys->cinfo, sizeof(sys->cinfo));
> }
>
> --
> 1.9.1
>
> --
> sheepdog mailing list
> sheepdog at lists.wpkg.org
> http://lists.wpkg.org/mailman/listinfo/sheepdog
More information about the sheepdog
mailing list