[sheepdog] [PATCH 2/2] fix array index error in function add_new_participant
Hitoshi Mitake
mitake.hitoshi at gmail.com
Mon Aug 11 15:45:45 CEST 2014
At Mon, 11 Aug 2014 18:11:44 +0800,
Ruoyu wrote:
>
> Nothing wrong with fixing it, alhough I don't know exactly
> what will be happened if not patching it.
>
> Signed-off-by: Ruoyu <liangry at ucweb.com>
> ---
> sheep/vdi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sheep/vdi.c b/sheep/vdi.c
> index 05cae7b..77dc253 100644
> --- a/sheep/vdi.c
> +++ b/sheep/vdi.c
> @@ -372,11 +372,12 @@ static bool add_new_participant(struct vdi_state_entry *entry,
> return true;
> }
>
> - idx = entry->nr_participants++;
> + idx = entry->nr_participants;
> memcpy(&entry->participants[idx], owner, sizeof(*owner));
> entry->participants_state[idx] =
> is_modified(entry) ?
> SHARED_LOCK_STATE_INVALIDATED : SHARED_LOCK_STATE_SHARED;
> + entry->nr_participants++;
I think this patch doesn't change the function. Does this fixes a bug?
Thanks,
Hitoshi
More information about the sheepdog
mailing list