[sheepdog] [PATCH] sheep/dog: introduce new bitmap for delete vdi

[Saeki Masaki]

(2014/12/03 21:18), Liu Yuan wrote:
> On Wed, Dec 03, 2014 at 08:01:16PM +0900, Saeki Masaki wrote:
>> Hi, Yuan
>>
>> Thank you for your comment.
>> but, SD_OP_READ_DEL_VDIS is already defined in "internal_proto.h" as below.
>> ---
>> #include "sheepdog_proto.h"
>> ---
>>
>> So, I think need not be add again.
>>
>
> Really? am I missing something? At least for master, it is defined at
>
> include/sheepdog_proto.h:#define SD_OP_READ_DEL_VDIS  0x18
>
> see following:
>
> yliu at ubuntu-trusty:~/sheepdog$ git grep 'SD_OP_READ_DEL_VDIS'
> dog/common.c:   sd_init_req(&req, SD_OP_READ_DEL_VDIS);
> include/sheepdog_proto.h:#define SD_OP_READ_DEL_VDIS  0x18
>
> I guess you got me wrong.
>
> sheepdog_proto.h is used for QEMU(or tgt)&sheep communication. internal_proto.h
> for dog & sheep. See the comment:
>
> /*
>   * This file specified the sheepdog-internal protocol, which is spoken between
>   * sheepdog daemons, as well as between dog and sheepdog daemon for internal
>   * operations.
>   */
>
> Thanks
> Yuan
>

Thank you for advice.
I was misunderstanding at specified rules of operation code.

I will soon post patch about this.

Regards,
Masaki Saeki.