[sheepdog] Fwd: [PATCH 2/2] sheep: forbid revival of orphan objects

[Hitoshi Mitake]

At Tue, 16 Dec 2014 15:11:49 +0100,
Valerio Pachera wrote:
> 
> 2014-12-11 8:00 GMT+01:00 Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>:
> > Current recovery process can cause revival of orphan objects. This
> > patch solves this problem.
> 
> sheep -v
> Sheepdog daemon version 0.9.0_18_g7215788
> 
> It works fine!
> 
> Dec 16 15:00:20   INFO [main] main(966) shutdown
> Dec 16 15:00:20   INFO [main] zk_leave(989) leaving from cluster
> Dec 16 15:00:37   INFO [main] md_add_disk(343) /mnt/sheep/0, vdisk nr
> 206, total disk 1
> Dec 16 15:00:37   INFO [main] md_add_disk(343) /mnt/sheep/1, vdisk nr
> 279, total disk 2
> Dec 16 15:00:37 NOTICE [main] get_local_addr(522) found IPv4 address
> Dec 16 15:00:37   INFO [main] send_join_request(1016) IPv4
> ip:192.168.10.7 port:7000 going to join the cluster
> Dec 16 15:00:37 NOTICE [main] nfs_init(611) nfs server service is not compiled
> Dec 16 15:00:37   INFO [main] main(958) sheepdog daemon (version
> 0.9.0_18_g7215788) started
> Dec 16 15:00:38   INFO [rw 30221] prepare_object_list(1100) skipping
> object list reading from IPv4 ip:192.168.10.7 port:7000 becauseit is
> marked as excluded node
> Dec 16 15:00:38   INFO [main] recover_object_main(930) object recovery
> progress   2%
> Dec 16 15:00:38   INFO [main] recover_object_main(930) object recovery
> progress   3%

Thanks for your checking, applied this series.

> 
> There's only this corner case to fix:
> all vdi are removed then and the disconnected node joins back the cluster

Do you mean the problem is the below error messages?

Thanks,
Hitoshi

> 
> Dec 16 14:55:09   INFO [main] zk_leave(989) leaving from cluster
> Dec 16 14:55:40   INFO [main] md_add_disk(343) /mnt/sheep/0, vdisk nr
> 206, total disk 1
> Dec 16 14:55:40   INFO [main] md_add_disk(343) /mnt/sheep/1, vdisk nr
> 279, total disk 2
> Dec 16 14:55:40 NOTICE [main] get_local_addr(522) found IPv4 address
> Dec 16 14:55:40   INFO [main] send_join_request(1016) IPv4
> ip:192.168.10.7 port:7000 going to join the cluster
> Dec 16 14:55:40 NOTICE [main] nfs_init(611) nfs server service is not compiled
> Dec 16 14:55:40   INFO [main] main(958) sheepdog daemon (version
> 0.9.0_18_g7215788) started
> Dec 16 14:55:41   INFO [rw 30049] prepare_object_list(1100) skipping
> object list reading from IPv4 ip:192.168.10.5 port:7000 becauseit is
> marked as excluded node
> Dec 16 14:55:41  ERROR [rw 30049] sheep_exec_req(1170) failed No
> object found, remote address: 192.168.10.5:7000, op name: GET_HASH
> Dec 16 14:55:41  ERROR [rw 30068] sheep_exec_req(1170) failed No
> object found, remote address: 192.168.10.5:7000, op name: GET_HASH
> Dec 16 14:55:41  ERROR [rw 30068] sheep_exec_req(1170) failed No
> object found, remote address: 192.168.10.6:7000, op name: GET_HASH
> Dec 16 14:55:41  ERROR [rw 30072] sheep_exec_req(1170) failed No
> object found, remote address: 192.168.10.5:7000, op name: GET_HASH
> Dec 16 14:55:41   INFO [main] recover_object_main(930) object recovery
> progress   1%
> <cut>
> -- 
> sheepdog mailing list
> sheepdog at lists.wpkg.org
> http://lists.wpkg.org/mailman/listinfo/sheepdog