[sheepdog] [PATCH] checkpatch: remove obsolete rule of min_t/max_t

Hitoshi Mitake mitake.hitoshi at gmail.com
Sat Jan 11 15:46:42 CET 2014


The souce tree of sheepdog doesn't have min_t/max_t.

Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
---
 script/checkpatch.pl | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/script/checkpatch.pl b/script/checkpatch.pl
index 520a5db..5df44c6 100755
--- a/script/checkpatch.pl
+++ b/script/checkpatch.pl
@@ -2812,29 +2812,6 @@ sub process {
 			}
 		}
 
-# typecasts on min/max could be min_t/max_t
-		if (defined $stat &&
-		    $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
-			if (defined $2 || defined $8) {
-				my $call = $1;
-				my $cast1 = deparenthesize($2);
-				my $arg1 = $3;
-				my $cast2 = deparenthesize($8);
-				my $arg2 = $9;
-				my $cast;
-
-				if ($cast1 ne "" && $cast2 ne "") {
-					$cast = "$cast1 or $cast2";
-				} elsif ($cast1 ne "") {
-					$cast = $cast1;
-				} else {
-					$cast = $cast2;
-				}
-				WARN("MINMAX",
-				     "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
-			}
-		}
-
 # check for new externs in .c files.
 		if ($realfile =~ /\.c$/ && defined $stat &&
 		    $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
-- 
1.8.1.2



More information about the sheepdog mailing list