On Mon, Jan 13, 2014 at 05:13:09PM +0800, Liu Yuan wrote:
> On Mon, Jan 13, 2014 at 05:40:36PM +0900, Hitoshi Mitake wrote:
> > The commit 6601e90cf2c5 (sheep: allow {register,unregister}_event to be called
> > in worker thread) introduced dangerous change of
> > {register,unregister}_event(). The changed functions are halfway thread safe. It
> > will be bug prone stuff and shoud be fixed in a correct manner. This patch adds
> > real thread safe version functions for registering and unregistering events.
>
> No, as we previously discussed, we need a high performance register/unregister
> mechanism for worker threads. Currently, exec_local_req_async is only user of it
> and current code serve it well.
>
> Queuing reg/unreg in the main thread is too slow.
"2. make sure registeration is done before some other events"
can main thread reg/unreg satisfy above requirements? I don't think so.
Thanks
Yuan
|
|