[sheepdog] [PATCH] fix two tricky bugs

Hitoshi Mitake mitake.hitoshi at gmail.com
Wed Jan 1 12:22:34 CET 2014


At Wed,  1 Jan 2014 17:30:15 +0800,
Robin Dong wrote:
> 
> From: Robin Dong <sanbai at taobao.com>
> 
> First bug, we should use argument 'vdi_inuse' for dog_exec_req() in parse_vdi()
> because 'vdi_inuse' is already the address of a memory-space. It will cause
> data corruption in some non-x86_64 machines.
> 
> Second bug, we  use 'goto out' in kv_create_object to avoid memory leak for
> 'onode'.
> 
> Signed-off-by: Robin Dong <sanbai at taobao.com>
> ---
>  dog/common.c    | 2 +-
>  sheep/http/kv.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Looks good to me.
Reviewed-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>

Thanks,
Hitoshi



More information about the sheepdog mailing list