[sheepdog] [PATCH v2 1/2] dog: fix wrong use of argument for dog_exec_req()

Hitoshi Mitake mitake.hitoshi at gmail.com
Thu Jan 2 09:09:14 CET 2014


At Thu,  2 Jan 2014 15:51:00 +0800,
Robin Dong wrote:
> 
> From: Robin Dong <sanbai at taobao.com>
> 
> It should use argument 'vdi_inuse' for dog_exec_req() in
> parse_vdi() and cluster_format() because 'vdi_inuse' is already the address
> of a memory-space. It will cause data corruption in some non-x86 machines.
> 
> Signed-off-by: Robin Dong <sanbai at taobao.com>
> ---
>  dog/cluster.c | 2 +-
>  dog/common.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Looks good to me.
Reviewed-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>

Thanks,
Hitoshi



More information about the sheepdog mailing list