[sheepdog] [PATCH stable-0.7] update for confusing treatment of copy policy

Liu Yuan namei.unix at gmail.com
Mon Jan 6 08:08:03 CET 2014


On Mon, Jan 06, 2014 at 01:33:22PM +0900, Hitoshi Mitake wrote:
> dog command of stable-0.7 allows a command line option like "3:1" as copy policy
> (-c option of vdi create and cluster format). e.g. "3:1" is interpreted as "3"
> because of the usage of strtol(). It is confusing for users when they need the
> erasure coded VDIs and clusters. So this patch lets dog command forbid such an
> option.
> 
> This update is not a backporting. If nobody disagree with this patch in 2 days
> or a maintainer accepts, this patch will be pushed to stable-0.7.
> 
> Hitoshi Mitake (1):
>   dog: forbid invalid copy policy option of cluster and vdi
> 
>  dog/cluster.c |    7 ++++++-
>  dog/vdi.c     |    7 ++++++-
>  2 files changed, 12 insertions(+), 2 deletions(-)

The patch looks good to me, and I think we should add

commit: e06d8e3 -- object cache: fix a wrong conversion assignment

to the stable too.

Thanks
Yuan



More information about the sheepdog mailing list