[sheepdog] [PATCH] Revert "sheep: remove invalid usage of current_vnode_info"

Liu Yuan namei.unix at gmail.com
Wed Jan 8 09:37:10 CET 2014


On Wed, Jan 08, 2014 at 04:58:14PM +0900, Hitoshi Mitake wrote:
> This reverts commit b82632b47978315a50e9ba0bbad59f56453f63f5.
> 
> The commit replaced main_thread_get() with get_vnode_info(). But the change was
> invalid because if we use get_vnode_info() for old_vnode_info, the reference
> count never reaches to 0. It causes resource leak. This patch reverts the
> commit.

I'd like you add some comment to the line that warn people if they tried to
do the same wrong thing again instead of a simple revert.

Thanks
Yuan



More information about the sheepdog mailing list