[sheepdog] [PATCH] logger: avoid using SIGHUP for detecting death of sheep

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Jan 21 11:27:07 CET 2014


At Mon, 20 Jan 2014 16:45:05 +0900,
MORITA Kazutaka wrote:
> 
> At Tue, 14 Jan 2014 17:46:26 +0900,
> Hitoshi Mitake wrote:
> > 
> > @@ -620,6 +607,15 @@ static void logger(char *log_dir, char *outfile)
> >  
> >  		unblock_sighup();
> >  
> > +		if (getppid() == 1) {
> > +			/* My parent (sheep process) is dead. */
> > +			log_flush();
> > +			closelog();
> > +			free_logarea();
> > +
> > +			exit(1);
> 
> Breaking this loop is simpler.  Otherwise, this patch looks good to
> me.

OK, I'll send v2 later.

Thanks,
Hitoshi



More information about the sheepdog mailing list