[sheepdog] [PATCH 2/2] sheep: cleaning vdi deletion process, round 2

Hitoshi Mitake mitake.hitoshi at gmail.com
Tue Jan 28 04:41:02 CET 2014


At Tue, 28 Jan 2014 11:11:49 +0800,
Liu Yuan wrote:
> 
> On Tue, Jan 28, 2014 at 11:38:22AM +0900, Hitoshi Mitake wrote:
> > This patch cleans the vdi deletion process of sheep. Current vdi
> > deletion code creates one work for one deletion. It seems that there
> > is no reason to create so many work. This patch lets the code to
> > create only one work for vdi deletion request.
> 
> why not? For now our deletion is very slow already, there are cases that
> multiple deletion requests will be issued by users. With your patch, concurrent
> deletions will be plainly slow to users.

The patch doesn't affect the performance of deletion. Because the
deletion workqueue is an ordered one.

Quoting from create_work_queues():
	sys->deletion_wqueue = create_ordered_work_queue("deletion");

Thanks,
Hitoshi



More information about the sheepdog mailing list