[sheepdog] [PATCH] dog: remove alter subcommand and migrate sub-sub commands

Ruoyu liangry at ucweb.com
Tue Jul 22 12:03:42 CEST 2014


On 2014年07月22日 17:46, Hitoshi Mitake wrote:
> At Tue, 22 Jul 2014 16:42:30 +0800,
> Ruoyu wrote:
>>
>> On 2014年07月22日 15:32, Hitoshi Mitake wrote:
>>>   static struct subcommand cluster_cmd[] = {
>>>   	{"info", NULL, "aprhvt", "show cluster information",
>>>   	 NULL, CMD_NEED_NODELIST, cluster_info, cluster_options},
>>> @@ -589,6 +670,8 @@ static struct subcommand cluster_cmd[] = {
>>>   	 cluster_reweight, cluster_options},
>>>   	{"check", NULL, "apht", "check and repair cluster", NULL,
>>>   	 CMD_NEED_NODELIST, cluster_check, cluster_options},
>>> +	{"alter-copy", NULL, "apht", "set the cluster's redundancy level",
>>> +	 NULL, CMD_NEED_NODELIST, cluster_alter_copy, cluster_options},
>> The option for the sub command alter-copy should be "capht", 'c' means 
>> '--copies'
> Thanks, I'll modify it before pushing if the idea is accepted.
>
>> In fact, this patch is something like the first submit I worked several 
>> weeks ago.
> Yes, I prefer the original one.
>
>> Yuan raised dog alter command at that time. I think it could be used to 
>> modify other settings in the future.
> I cannot imagine the other settings. Do you have some ideas?
No idea yet. I prefer this patch too. What about Yuan's opinion?
>
> Thanks,
> Hitoshi
>
>





More information about the sheepdog mailing list