[sheepdog] [PATCH 09/10] sheep/vdi: clear performance tips generated by cppcheck

Ruoyu liangry at ucweb.com
Tue Sep 2 11:14:12 CEST 2014


This patch gets rid of the below message while performing a code
analysis with cppcheck.

[sheep/vdi.c:275] -> [sheep/vdi.c:278]: (performance) Variable 'ret' is
reassigned a value before the old one has been used.
[sheep/vdi.c:1239] -> [sheep/vdi.c:1249]: (performance) Variable 'ret'
is reassigned a value before the old one has been used.
[sheep/vdi.c:1376] -> [sheep/vdi.c:1382]: (performance) Variable 'ret'
is reassigned a value before the old one has been used.

Signed-off-by: Ruoyu <liangry at ucweb.com>
---
 sheep/vdi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sheep/vdi.c b/sheep/vdi.c
index 0adbea0..f1de98c 100644
--- a/sheep/vdi.c
+++ b/sheep/vdi.c
@@ -272,7 +272,7 @@ static inline bool vdi_is_deleted(struct sd_inode *inode)
 int vdi_exist(uint32_t vid)
 {
 	struct sd_inode *inode;
-	int ret = 1;
+	int ret;
 
 	inode = xzalloc(sizeof(*inode));
 	ret = sd_read_object(vid_to_vdi_oid(vid), (char *)inode,
@@ -1236,7 +1236,7 @@ int vdi_lookup(const struct vdi_iocb *iocb, struct vdi_info *info)
 static int notify_vdi_add(uint32_t vdi_id, uint32_t nr_copies, uint32_t old_vid,
 			  uint8_t copy_policy)
 {
-	int ret = SD_RES_SUCCESS;
+	int ret;
 	struct sd_req hdr;
 
 	sd_init_req(&hdr, SD_OP_NOTIFY_VDI_ADD);
@@ -1373,7 +1373,7 @@ struct deletion_work {
 static int notify_vdi_deletion(uint32_t vdi_id)
 {
 	struct sd_req hdr;
-	int ret = SD_RES_SUCCESS;
+	int ret;
 
 	sd_init_req(&hdr, SD_OP_NOTIFY_VDI_DEL);
 	hdr.flags = SD_FLAG_CMD_WRITE;
-- 
1.8.3.2





More information about the sheepdog mailing list