[sheepdog] [PATCH 1/4] dog/cluster: bug fix when cluster don't have snapshots

Hitoshi Mitake mitake.hitoshi at lab.ntt.co.jp
Thu Sep 11 06:50:27 CEST 2014


At Thu, 11 Sep 2014 11:03:44 +0800,
Ruoyu wrote:
> 
> 
> On 2014年09月11日 10:23, Hitoshi Mitake wrote:
> > At Wed, 10 Sep 2014 15:51:55 +0800,
> > Ruoyu wrote:
> >> This patch fix the problem as below.
> >>
> >> this is the first cluster snapshot I try to save, but I forgot to snapshot
> >> the vdi:
> >>
> >> dog cluster snapshot save first cluster_snapshots
> >>
> >> Object not found. It may be caused by:
> >> 1. The cluster is empty.
> >> 2. All VDIs of the cluster don't have snapshots.
> >>
> >> and that's right!
> >>
> >> Then I take vdi snapshot and save cluster snapshot, then remove vdi snapshots.
> >> Now I try to make the same mistake
> >>
> >> dog cluster snapshot save second cluster_snapshots
> >> 100.0 % [=====] 4 / 4
> >>
> >> There are no vdi snapshots and dog doesn't complain about it!
> >> It did it only the first time.
> >>
> >> Reported-by: Valerio Pachera <sirio81 at gmail.com>
> >> Signed-off-by: Ruoyu <liangry at ucweb.com>
> >> ---
> >>   dog/cluster.c   | 8 ++++++--
> >>   dog/farm/farm.h | 1 +
> >>   2 files changed, 7 insertions(+), 2 deletions(-)
> > Applied this series, thanks. BTW, could you provide a cover letter for
> > seriesed patches?
> OK.
> May I ask a question? How to add a cover letter for seriesed patches?

You can create a stub of cover letter with --cover-letter option of
git format-patch.

Thanks,
Hitoshi



More information about the sheepdog mailing list