[sheepdog] [sheepdog/sheepdog] 564797: sheep: avoid panic in COW when sheep fails to allo...

Hitoshi Mitake mitake.hitoshi at gmail.com
Sun Aug 16 14:56:41 CEST 2015


  Branch: refs/heads/master
  Home:   https://github.com/sheepdog/sheepdog
  Commit: 5647976158ff459cc97a688dd42d7a7cd87a2a39
      https://github.com/sheepdog/sheepdog/commit/5647976158ff459cc97a688dd42d7a7cd87a2a39
  Author: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
  Date:   2015-08-15 (Sat, 15 Aug 2015)

  Changed paths:
    M sheep/gateway.c

  Log Message:
  -----------
  sheep: avoid panic in COW when sheep fails to allocate memory

Current code for COW requests can call panic() because it uses
xzalloc() and xcalloc() for processing the requests. This commit lets
the code avoid use the functions and return SD_RES_NO_MEM because COW
is a very common and frequent request. It is better to return error
code to VMs than killing sheep.

Even if the memory allocations fail, it just causes object leaks. This
behavior is not changed from the existing strategy which calls
panic().

Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>


  Commit: 748b2dcc0461a42ec6363c376dab4a7b72f2db3a
      https://github.com/sheepdog/sheepdog/commit/748b2dcc0461a42ec6363c376dab4a7b72f2db3a
  Author: Hitoshi Mitake <mitake.hitoshi at gmail.com>
  Date:   2015-08-16 (Sun, 16 Aug 2015)

  Changed paths:
    M sheep/gateway.c

  Log Message:
  -----------
  Merge pull request #121 from sheepdog/enomem

sheep: avoid panic in COW when sheep fails to allocate memory


Compare: https://github.com/sheepdog/sheepdog/compare/a4db5e30b006...748b2dcc0461


More information about the sheepdog mailing list