[sheepdog] [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

[Eric Blake]

On 02/12/2015 06:49 AM, Markus Armbruster wrote:
> If do_sd_create() fails, it first reports the error returned, then
> reports a another one with strerror(errno).  errno is meaningless at
> that point.
> 
> Report just one error combining the valid information from both
> messages.
> 
> Reported-by: Eric Blake <eblake at redhat.com>
> Signed-off-by: Markus Armbruster <armbru at redhat.com>
> ---
> Applies on top of my "[PATCH v2 00/10] Clean up around
> error_get_pretty(), qerror_report_err()", but rebasing to master would
> be trivial.
> 
>  block/sheepdog.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://lists.wpkg.org/pipermail/sheepdog/attachments/20150212/043d7eae/attachment-0004.sig>