[sheepdog] [Qemu-devel] [PATCH v2] sheepdog: fix confused return values

Stefan Hajnoczi stefanha at gmail.com
Fri Feb 27 12:29:53 CET 2015


On Wed, Feb 18, 2015 at 11:57:55AM +0800, Liu Yuan wrote:
> From: Liu Yuan <liuyuan at cmss.chinamobile.com>
> 
> These functions mix up -1 and -errno in return values and would might cause
> trouble error handling in the call chain.
> 
> This patch let them return -errno and add some comments.
> 
> Cc: qemu-devel at nongnu.org
> Cc: Markus Armbruster <armbru at redhat.com>
> Cc: Kevin Wolf <kwolf at redhat.com>
> Cc: Stefan Hajnoczi <stefanha at redhat.com>
> Reported-by: Markus Armbruster <armbru at redhat.com>
> Signed-off-by: Liu Yuan <liuyuan at cmss.chinamobile.com>
> ---
> v2:
>  - use socket_error() instead of errno
> 
>  block/sheepdog.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.wpkg.org/pipermail/sheepdog/attachments/20150227/c9645653/attachment-0004.sig>


More information about the sheepdog mailing list