[sheepdog] [PATCH] sbd: use kstrtoul() instead of strict_strtoul()

[hujianyang]

On 2015/1/20 11:01, Hitoshi Mitake wrote:
> At Tue, 20 Jan 2015 11:46:32 +0900,
> Hitoshi Mitake wrote:
>>
>> Cc: hujianyang <hujianyang at huawei.com>
>> Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
>> ---
>>  sbd/sheep_block_device.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Dropping it. The version information should be described about the interfaces.
> 
> Thanks,
> Hitoshi
> 

Seems *kstrtoul* is introduce into mainline since commit 33ee3b2e2:

commit 33ee3b2e2eb9b4b6c64dcf9ed66e2ac3124e748c
Author: Alexey Dobriyan <adobriyan at gmail.com>
Date:   Tue Mar 22 16:34:40 2011 -0700

      kstrto*: converting strings to integers done (hopefully) right

An old kernel maybe not support this interface, but I don't like
the module code is written as:

#ifdef KERNEL_VERSION<(x,x,x)
	...
#else
	...
#endif

What's your opinion?

Add Cc Alexey Dobriyan <adobriyan at gmail.com>

>>
>> diff --git a/sbd/sheep_block_device.c b/sbd/sheep_block_device.c
>> index eaee932..d82ff43 100644
>> --- a/sbd/sheep_block_device.c
>> +++ b/sbd/sheep_block_device.c
>> @@ -290,7 +290,7 @@ static ssize_t sbd_remove(struct bus_type *bus, const char *buf,
>>  	unsigned long ul;
>>  	int target_id, ret;
>>  
>> -	ret = strict_strtoul(buf, 10, &ul);
>> +	ret = kstrtoul(buf, 10, &ul);
>>  	if (ret)
>>  		return ret;
>>  
>> -- 
>> 1.9.1
>>
> 
>