[sheepdog] [PATCH v2] tools/zk_control: add sort options for list subcommand

[Roy Yang]

Thanks for explanation!
If that is the case,  make sense why we don't use xqsort for now.
Roy

Date: Fri, 6 Mar 2015 12:58:38 +0800
From: menglingkun at cmss.chinamobile.com
To: bsdnet at outlook.com; namei.unix at gmail.com; starmlk at 163.com
CC: sheepdog at lists.wpkg.org
Subject: RE: RE: [sheepdog] [PATCH v2] tools/zk_control: add sort options for list subcommand


Yes, I saw it. However, if xqort in util.h used, zk_control can't be linked beacuse of the current makefile.And if modify the current makefile to be linked,  it will make zk_control much larger.Because the xqosrt used function log_write, which is compiled in libsheepdog.a.Maybe having better way, but it will change a lot? 
So after discussing with Yuan, just used qsort like xqsort just without using assert (log_write in it).
Lingkun

> Saw there is a wrapper function called xqsort in util.h, should it be used?
> 
> Roy
> 
> > Date: Fri, 6 Mar 2015 11:48:52 +0800
> > From: namei.unix at gmail.com
> > To: starmlk at 163.com
> > CC: sheepdog at lists.wpkg.org; menglingkun at cmss.chinamobile.com
> > Subject: Re: [sheepdog] [PATCH v2] tools/zk_control: add sort options for list subcommand
> > 
> > On Thu, Mar 05, 2015 at 01:47:28PM +0800, Meng Lingkun wrote:
> > > From: Meng Lingkun <menglingkun at cmss.chinamobile.com>
> > > 
> > > It's more useable to list the sequential znodes in queue with sort function.
> > > And we always focus on the lastest zndode in queue, so sort in reverse order.
> > > 
> > 
> > Applied after I reversed the list order.
> > 
> > Yuan
> > -- 
> > sheepdog mailing list
> > sheepdog at lists.wpkg.org
> > https://lists.wpkg.org/mailman/listinfo/sheepdog
 		 	   		  
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wpkg.org/pipermail/sheepdog/attachments/20150305/6d958dc5/attachment-0004.html>