[sheepdog] [PATCH v4 1/3] sheep: handle VID overflow correctly

[Hitoshi Mitake]

At Thu, 12 Mar 2015 09:57:51 +0800,
Liu Yuan wrote:
> 
> On Sun, Mar 08, 2015 at 01:08:33PM +0900, Hitoshi Mitake wrote:
> > Current sheep cannot handle a case of VID overflow correctly. The main
> > cause of this problem is invalid usage of fill_vdi_info_range() by
> > fill_vdi_info() in a case of overflow. This patch fixes this problem.
> 
> Could you please describe the problem in detail? what is invalid usage?
> 
> > In addition, this patch lets 0x000000 be an invalid VID. It is for VID
> > recycling. In some places of sheepdog, parent_vid is used as a
> > value which indicates that the VDI has a parent (clone or snapshot) or
> > not (working VDI). So this patch lets the first VID 0x000001 and
> > prevent this sort of confusion.
> 
> I think this should be in a separate patch for better review.

OK. I'll rework this patch after finishing the discussion of VID recycling.

Thanks,
Hitoshi

> 
> Thanks,
> Yuan
> -- 
> sheepdog mailing list
> sheepdog at lists.wpkg.org
> https://lists.wpkg.org/mailman/listinfo/sheepdog