[sheepdog] [PATCH 0/2] A better way to remove queue nodes

Hitoshi Mitake mitake.hitoshi at gmail.com
Thu Mar 12 12:33:51 CET 2015


At Mon,  9 Mar 2015 13:08:55 +0800,
Meng Lingkun wrote:
> 
> Zookeeper cluster driver can't and doesn't delete the znode in queue
> after using it. It makes zookeeper occupy much more memory. And it makes
> troubles when zookeeper client reconnects to zookeeper server.
> reference: https://issues.apache.org/jira/browse/ZOOKEEPER-706
> Subcommand delete provides a better way than purge subcommand:
> 1. sheep update it's queue_pos to zookeeper server;
> 2. zk_control find the minimum of all sheeps' queue_pos, and removes
>    znodes seq < minimum;
> 3. zk_control can run in crond to limit the queue znode.
> 
> Meng Lingkun (2):
>   zookeeper: update queue_pos to zookeeper-server
>   tools/zk_control: add detele subcommand to remove queue nodes
> 
>  sheep/cluster/zookeeper.c | 32 +++++++++++++++++
>  tools/zk_control.c        | 88 ++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 119 insertions(+), 1 deletion(-)

Hi Meng,

Thanks a lot for your patches. But could you Cc Ruoyu
(liangry at ucweb.com) from next time when you send patches which change
zookeeper related code? He is the subsystem maintainer, so at least
you should let him know about changes for the components. And he would
be able to give you nice comments.

Thanks,
Hitoshi

> 
> -- 
> 1.9.1
> 
> 
> 
> -- 
> sheepdog mailing list
> sheepdog at lists.wpkg.org
> https://lists.wpkg.org/mailman/listinfo/sheepdog



More information about the sheepdog mailing list