[sheepdog] [sheepdog/sheepdog] 9c6514: remove inode update prevention

Hitoshi Mitake mitake.hitoshi at lab.ntt.co.jp
Fri Oct 9 03:22:23 CEST 2015


  Branch: refs/heads/lock-disable
  Home:   https://github.com/sheepdog/sheepdog
  Commit: 9c651420c4bb6c9021e94204a492b397c4a999f9
      https://github.com/sheepdog/sheepdog/commit/9c651420c4bb6c9021e94204a492b397c4a999f9
  Author: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
  Date:   2015-10-09 (Fri, 09 Oct 2015)

  Changed paths:
    M dog/vdi.c
    M include/internal_proto.h
    M lib/shared/vdi.c
    M sheep/group.c
    M sheep/ops.c
    M sheep/request.c
    M sheep/sheep_priv.h

  Log Message:
  -----------
  remove inode update prevention

The mechanism of inode update prevention mechanism was introduced in
the commit 449331b4d0c. The original motivation of this mechanism was
for reducing object leak which can happen during taking
snapshot. However, the object leak problem seems to be solved in the
qemu side commit 20760b16b73. I've been kept the mechanism because it
was useful for hiding incomplete state of VDIs (snapshot is created
but new working VDI isn't created yet) from clients. For simplifing
the design of sheepdog, the problem should be handled in the clients.

The retrying mechanism in the qemu driver is already ongoing:
https://github.com/sheepdog/qemu/tree/reconnect-and-reload

Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>


  Commit: a8a7d118ffc3bf96017ac6639dccd28b99795be8
      https://github.com/sheepdog/sheepdog/commit/a8a7d118ffc3bf96017ac6639dccd28b99795be8
  Author: Vasiliy Tolstov <v.tolstov at selfip.ru>
  Date:   2015-10-09 (Fri, 09 Oct 2015)

  Changed paths:
    M sbd/sheep_block_device.c

  Log Message:
  -----------
  sbd: fix strict_strtoul for newer kernels

strict_strtoul() was just a redefinition of kstrtoul() for a long
time. From kernel version of 3.18, strict_strtoul() will not be
defined at all. A compile time kernel version check is needed to
decide which function or macro can be used for a specific version of
kernel.

Signed-off-by: Vasiliy Tolstov <v.tolstov at selfip.ru>


  Commit: eb53d6925a31f3c9063e8dc33e48a1af5b793685
      https://github.com/sheepdog/sheepdog/commit/eb53d6925a31f3c9063e8dc33e48a1af5b793685
  Author: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
  Date:   2015-10-09 (Fri, 09 Oct 2015)

  Changed paths:
    M sheep/ops.c

  Log Message:
  -----------
  sheep: disable locking in a correct manner if -l isn't passed

Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>


Compare: https://github.com/sheepdog/sheepdog/compare/9c651420c4bb^...eb53d6925a31


More information about the sheepdog mailing list