[sheepdog] [PATCH 2/2] sheepdog: refine discard support
mitake.hitoshi at gmail.com
Fri Sep 4 10:51:49 CEST 2015
On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov <v.tolstov at selfip.ru> wrote:
> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>:
>> This patch refines discard support of the sheepdog driver. The
>> existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, which
>> was introduced before fine grained reference counting on newer
>> sheepdog. It doesn't care about relations of snapshots and clones and
>> discards objects unconditionally.
>> With this patch, the driver just updates an inode object for updating
>> reference. Removing the object is done in sheep process side.
>> Cc: Teruaki Ishizaki <ishizaki.teruaki at lab.ntt.co.jp>
>> Cc: Vasiliy Tolstov <v.tolstov at selfip.ru>
>> Cc: Jeff Cody <jcody at redhat.com>
>> Signed-off-by: Hitoshi Mitake <mitake.hitoshi at lab.ntt.co.jp>
> I'm test this patch and now discard working properly and no errors in
> sheepdog log file.
> Tested-by: Vasiliy Tolstov <v.tolstov at selfip.ru>
On the second thought, this patch has a problem of handling snapshot.
Please drop this one (1st patch is ok to apply).
I'll solve the problem in sheepdog side.
> Vasiliy Tolstov,
> e-mail: v.tolstov at selfip.ru
> sheepdog mailing list
> sheepdog at lists.wpkg.org
More information about the sheepdog