[sheepdog] [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create

Maxim Levitsky mlevitsk at redhat.com
Thu Mar 26 14:22:01 CET 2020


On Thu, 2020-03-26 at 08:18 -0500, Eric Blake wrote:
> On 3/25/20 8:12 PM, Maxim Levitsky wrote:
> > This will allow to reuse a single generic .bdrv_co_create
> 
> "allow to ${verb}" is not idiomatic, better is "allow ${subject} to 
> ${verb}" or "allow ${verb}ing".  In this case, I'd go with:
> 
> This will allow the reuse of a single...
I agree! This commit will probably go as is but next time I'll keep it in mind!

Best regards,
	Maxim Levitsky

> 
> > implementation for several drivers.
> > No functional changes.
> > 
> > Signed-off-by: Maxim Levitsky <mlevitsk at redhat.com>
> > ---




More information about the sheepdog mailing list