[sheepdog] [PATCH v2 0/2] block: deprecate the sheepdog driver

[Vladimir Sementsov-Ogievskiy]

22.09.2020 21:11, Neal Gompa wrote:
> On Tue, Sep 22, 2020 at 1:43 PM Daniel P. Berrangé <berrange at redhat.com> wrote:
>>
>> On Tue, Sep 22, 2020 at 01:09:06PM -0400, Neal Gompa wrote:
>>> On Tue, Sep 22, 2020 at 12:16 PM Daniel P. Berrangé <berrange at redhat.com> wrote:
>>>>
>>>> 2 years back I proposed dropping the sheepdog mailing list from the
>>>> MAINTAINERS file, but somehow the patch never got picked up:
>>>>
>>>>    https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html
>>>>
>>>> So here I am with the same patch again.
>>>>
>>>> This time I go further and deprecate the sheepdog driver entirely.
>>>> See the rationale in the second patch commit message.
>>>>
>>>> Daniel P. Berrangé (2):
>>>>    block: drop moderated sheepdog mailing list from MAINTAINERS file
>>>>    block: deprecate the sheepdog block driver
>>>>
>>>>   MAINTAINERS                |  1 -
>>>>   block/sheepdog.c           | 15 +++++++++++++++
>>>>   configure                  |  5 +++--
>>>>   docs/system/deprecated.rst |  9 +++++++++
>>>>   4 files changed, 27 insertions(+), 3 deletions(-)
>>>>
>>>> --
>>>> 2.26.2
>>>>
>>>>
>>>
>>> I don't know of anyone shipping this other than Fedora, and I
>>> certainly don't use it there.
>>>
>>> Upstream looks like it's unmaintained now, with no commits in over two
>>> years: https://github.com/sheepdog/sheepdog/commits/master
>>>
>>> Can we also get a corresponding change to eliminate this from libvirt?
>>
>> This is only deprecation in QEMU, the feature still exists and is
>> intended to be as fully functional as in previous releases.
>>
>> Assuming QEMU actually deletes the feature at end of the deprecation
>> cycle, then libvirt would look at removing its own support.
>>
> 
> Does that stop us from deprecating it in libvirt though?
> 

I think not. Libvirt is not intended to support all Qemu features and
I'm sure it doesn't. Amd it can safely deprecate features even if they
are not-deprecated in Qemu.

The only possible conflict is when Qemu wants to deprecate something
that Libvirt wants to continue support for (or even can't live without).

-- 
Best regards,
Vladimir