<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:14px">in the cluster_recovery_completion function,i think</span><br style="font-family:arial,sans-serif;font-size:14px"><span style="font-family:arial,sans-serif;font-size:14px">memcmp(vnode_info->nodes, recovereds,sizeof(*recovereds) *</span><br style="font-family:arial,sans-serif;font-size:14px">
<span style="font-family:arial,sans-serif;font-size:14px">nr_recovereds) == 0 line have a bug.</span><br style="font-family:arial,sans-serif;font-size:14px"><span style="font-family:arial,sans-serif;font-size:14px">beceuse the Function parameter vnode_info->nodes and recovereds will </span><span style="font-family:arial,sans-serif;font-size:14px">have different nr_vnodes number after recovery completion.vnode_info-></span><span style="font-family:arial,sans-serif;font-size:14px">nodes of nr_vnodes variable calculated by recalculate_vnodes </span><font face="arial, sans-serif"><span style="font-size:14px">function.In my environment it is 61 and 67.</span></font><div>
<font face="arial, sans-serif"><span style="font-size:14px">and recovereds of nr_vnodes variable is a fixed value.It is usually 64.</span></font><br style="font-family:arial,sans-serif;font-size:14px"><span style="font-family:arial,sans-serif;font-size:14px">in this case sd_store->cleanup() will not be executed.</span><br>
<div><span style="font-family:arial,sans-serif;font-size:14px"><br></span></div><div style><span style="font-family:arial,sans-serif;font-size:14px">for example.</span><span style="font-size:14px;font-family:arial,sans-serif">If the the node1 disk size is 1G,node2 is 2G node3 is 3G. </span><span style="font-family:arial,sans-serif;font-size:14px">sd_store->cleanup() will not be executed forever.</span></div>
<div style><span style="font-family:arial,sans-serif;font-size:14px"><br></span></div><div style><span style="font-family:arial,sans-serif;font-size:14px"><br></span></div><div style><font face="arial, sans-serif"><span style="font-size:14px">Thanks</span></font></div>
<div style><font face="arial, sans-serif"><span style="font-size:14px">Fan</span></font></div></div></div>