<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 28, 2013, at 11:41 AM, Liu Yuan <<a href="mailto:namei.unix@gmail.com">namei.unix@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; ">The current master election process is too complicted to me, the payback is to</span><br style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; ">solve a very unusal corner startup case. I guess it needs time to get stablized,</span><br style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; ">Is this really worthwhile? We should reconsider the old method, since it is quit</span><br style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; ">simple and well tested. What do you think?</span></blockquote></div><br><div>To be honest, I have an opposite opinion. </div><div><br></div><div>- I don't think the current master election process is too complicated.</div><div> There is only one simple rule: sheep with the least sequential number become master.</div><div> And this is also a standard way that is suggested officially.</div><div> And I believe there are many distributed systems are using the same way for master election.</div><div><br></div><div>- It is not an unusual case, every time when network is crowd for a long time, it will be sure to happen.</div><div><br></div><div>- The current zookeeper driver has been tested under several situations.</div><div> In addition, I will also start to do more testings as soon as possible.</div><div> I think I can manage to fix any problem about the stability.</div><div><br></div><div>- I don't think 'quit' is a good manner in a production environment. We should do our best</div><div> to protect them from quit. (This is because a 'quit' will be aware by Guest OS)</div><div><br></div><div>- Based on our testing results, the previous zookeeper driver is not quite stable, at least, not as stable as corosync.</div><div><br></div><div>- Maybe the complexity is caused by the current implementation. I think we can clean code if needed.</div><div> However, I prefer the dirty code which can do right things than a clean code which contains bugs.</div><div> The original intention of the patch is that previous implementation has fatal error.</div><div><br></div><div>Thanks,</div><div>Kyle</div></body></html>