<div dir="ltr">Looks good to me.<div><br></div><div>Reviewed-by: Robin Dong <<a href="mailto:sanbai@taobao.com">sanbai@taobao.com</a>></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/12/1 Liu Yuan <span dir="ltr"><<a href="mailto:namei.unix@gmail.com" target="_blank">namei.unix@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> /* one liner */<br>
...<br>
some stuff<br>
...<br>
 * blabla<br>
 * blabla<br>
 */<br>
<br>
Above is a valid comment, but current check will warn falsely<br>
<br>
Signed-off-by: Liu Yuan <<a href="mailto:namei.unix@gmail.com">namei.unix@gmail.com</a>><br>
---<br>
 script/<a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a> |    4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/script/<a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a> b/script/<a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a><br>
index c57380b..520a5db 100755<br>
--- a/script/<a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a><br>
+++ b/script/<a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a><br>
@@ -1734,8 +1734,8 @@ sub process {<br>
                                     "[BCS] don't use block comments for one liner comment\n" . $hereprev);<br>
                        } else {<br>
                                # case E<br>
-                               my $ln = $linenr;<br>
-                               while ($rawlines[$ln] !~ /^\+\s*\/\*/ && $ln >= 0) { $ln--; }<br>
+                               my $ln = $linenr - 1;<br>
+                               while ($rawlines[$ln] =~ /^\+/ && $rawlines[$ln] !~ /^\+\s*\/\*/ && $ln >= 0) { $ln--; }<br>
                                if ($rawlines[$ln] =~ /^\+\s*\/\*./) {<br>
                                        WARN("BLOCK_COMMENT_STYLE",<br>
                                             "[BCS] don't comment at first line in block comments\n" . $hereprev);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.9.5<br>
<br>
--<br>
sheepdog mailing list<br>
<a href="mailto:sheepdog@lists.wpkg.org">sheepdog@lists.wpkg.org</a><br>
<a href="http://lists.wpkg.org/mailman/listinfo/sheepdog" target="_blank">http://lists.wpkg.org/mailman/listinfo/sheepdog</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>--<br>Best Regard<br>Robin Dong
</div>